This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Fix bug where word match includes colon#353
Merged
wingrunr21 merged 4 commits intorubyide:masterfrom Jun 18, 2018
toddmazierski:257-word-match-includes-colon
Merged
Fix bug where word match includes colon#353wingrunr21 merged 4 commits intorubyide:masterfrom toddmazierski:257-word-match-includes-colon
wingrunr21 merged 4 commits intorubyide:masterfrom
toddmazierski:257-word-match-includes-colon
Conversation
Extract `languageConfiguration` to a separate module so it can more easily be unit tested.
Add a `test` task to run Mocha. Also add it to the Travis CI configuration.
Add a test to reproduce bug #257, where leading colons in symbols and constants were matched as words.
Collaborator
|
Awesome, thanks! |
Contributor
Author
|
Thank you, @wingrunr21! By the way, it looks like the last Travis CI build for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before submitting your PR -- thanks in advance!
--
Fix bug #257 where the word match includes leading colons. Include a test to demonstrate the desired behavior.
Thanks for considering this!